Bug: Custom listener + consuming insets

[mlykotom]

In method applyToView and checking for custom listener, there's probably a bug with checking if insets should be consumed.

insetter/library/src/main/java/dev/chrisbanes/insetter/Insetter.kt

Line 373 in 2724d46

return@setOnApplyWindowInsetsListener if (consume != CONSUME_NONE) insets

The problem is in the if condition - it should be reverted and therefore if(consume == CONSUME_NONE) insets else WindowInsetsCompat.CONSUMED because when none consumed, then we should return the initial insets, right?

This breaks insetter when custom listener is applied somewhere in the view hierarchy.

[dimsuz]

Aha! So that's why it broke for me after upgrade. I heavily rely on custom listener in my setup.

Any chance this will be released soon?

[dimsuz]

Friendly ping @chrisbanes. Currently have to use an obsolete library version and also getting a lot of insets-related @Deprecated warnings. I can't easily work around this bug (or can I?).

Do you plan on releasing a new minor version in the near future?

[chrisbanes]

My bad, I’ll release a new version tomorrow!

[dimsuz]

Hurray, thank you!