Track the root cause of the composition looping

Thanks to @adamp for catching this. We were not remembering any
LiveData transformations around insets, which meant that the
stream was being created on every call.

Fixed by remembering the transformed LiveData, and then
observing that. Meaning we can go back to `ambientOf`.

common-ui-compose/src/main/java/app/tivi/common/compose/Debug.kt

@@ -14,25 +14,30 @@
  * limitations under the License.
  */
 
+@file:Suppress("NOTHING_TO_INLINE")
+
 package app.tivi.common.compose
 
 import android.util.Log
 import androidx.compose.Composable
 import androidx.compose.onCommit
 import androidx.compose.remember
 
-private class Ref(var value: Int)
+class Ref(var value: Int)
 
-private const val EnableDebugCompositionLogs = false
+const val EnableDebugCompositionLogs = false
 
 /**
  * An effect which longs the number compositions at the invoked point of the slot table.
  * Thanks to [objcode](https://github.com/objcode) for this code.
  *
+ * This is an inline function to act as like a C-style #include to the host composable function.
+ * That way we track it's compositions, not this function's compositions.
+ *
  * @param tag Log tag used for [Log.d]
  */
 @Composable
-fun LogCompositions(tag: String) {
+inline fun LogCompositions(tag: String) {
     if (EnableDebugCompositionLogs && BuildConfig.DEBUG) {
         val ref = remember { Ref(0) }
         onCommit { ref.value++ }

common-ui-compose/src/main/java/app/tivi/common/compose/insets.kt

@@ -19,7 +19,8 @@ package app.tivi.common.compose
 import android.view.View
 import androidx.compose.Composable
 import androidx.compose.Providers
-import androidx.compose.staticAmbientOf
+import androidx.compose.ambientOf
+import androidx.compose.remember
 import androidx.core.view.ViewCompat
 import androidx.core.view.WindowInsetsCompat
 import androidx.core.view.doOnAttach
@@ -47,17 +48,17 @@ data class InsetsHolder(
     val vertical get() = top + bottom
 }
 
-val InsetsAmbient = staticAmbientOf { InsetsHolder() }
+val InsetsAmbient = ambientOf { InsetsHolder() }
 
 @Composable
 fun ProvideInsets(
     liveData: LiveData<WindowInsetsCompat?>,
     children: @Composable () -> Unit
 ) {
-    val currentInsets = liveData
-        .map { if (it != null) InsetsHolder(it) else InsetsHolder() }
-        .distinctUntilChanged()
-        .observeAsState(InsetsHolder())
+    val currentInsets = remember(liveData) {
+        liveData.map { if (it != null) InsetsHolder(it) else InsetsHolder() }
+            .distinctUntilChanged()
+    }.observeAsState(InsetsHolder())
 
     Providers(InsetsAmbient provides currentInsets.value) {
         children()