Skip to content

Commit

Permalink
Remove codestyle CI job (#1721)
Browse files Browse the repository at this point in the history
* Ignore disabled KMP targets

* Remove codestyle job
  • Loading branch information
chrisbanes committed Jan 23, 2024
1 parent 4694c02 commit d7d258e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 39 deletions.
42 changes: 3 additions & 39 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,42 +10,7 @@ on:
workflow_dispatch:

jobs:
code-style:
runs-on: macos-latest
timeout-minutes: 60
env:
ORG_GRADLE_PROJECT_REMOTE_BUILD_CACHE_URL: ${{ secrets.ORG_GRADLE_PROJECT_REMOTE_BUILD_CACHE_URL }}
ORG_GRADLE_PROJECT_REMOTE_BUILD_CACHE_USERNAME: ${{ secrets.ORG_GRADLE_PROJECT_REMOTE_BUILD_CACHE_USERNAME }}
ORG_GRADLE_PROJECT_REMOTE_BUILD_CACHE_PASSWORD: ${{ secrets.ORG_GRADLE_PROJECT_REMOTE_BUILD_CACHE_PASSWORD }}

steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4

- name: set up JDK
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: 21

- uses: ruby/setup-ruby@v1
with:
bundler-cache: true

- uses: gradle/gradle-build-action@v2
with:
cache-disabled: true

- name: Check convention plugins code style with Spotless
run: ./gradlew -p gradle/build-logic spotlessCheck

- name: Check code style with Spotless
run: ./gradlew spotlessCheck

- name: Check code style with SwiftLint
run: bundle exec fastlane ios lint

android:
needs: [code-style]
runs-on: ubuntu-latest
timeout-minutes: 60
env:
Expand Down Expand Up @@ -116,7 +81,6 @@ jobs:
**/build/test-results/*
desktop:
needs: [code-style]
runs-on: ubuntu-latest
timeout-minutes: 60
env:
Expand Down Expand Up @@ -170,7 +134,6 @@ jobs:
**/build/test-results/*
ios-qa-app:
needs: [code-style]
runs-on: macos-13
timeout-minutes: 60
env:
Expand Down Expand Up @@ -208,6 +171,9 @@ jobs:
env:
ENCRYPT_KEY: ${{ secrets.ENCRYPT_KEY }}

- name: Run Fastlane Lint lane
run: bundle exec fastlane ios lint

- name: Build iOS application
run: bundle exec fastlane ios build_qa
env:
Expand Down Expand Up @@ -237,7 +203,6 @@ jobs:
**/fastlane-buildlog
ios-prod-app:
needs: [code-style]
runs-on: macos-13
timeout-minutes: 60
env:
Expand Down Expand Up @@ -304,7 +269,6 @@ jobs:
**/fastlane-buildlog
ios-test:
needs: [code-style]
runs-on: macos-13
timeout-minutes: 60
env:
Expand Down
2 changes: 2 additions & 0 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,7 @@ android.defaults.buildFeatures.buildConfig=false

kotlin.mpp.androidSourceSetLayoutVersion=2
kotlin.mpp.androidGradlePluginCompatibility.nowarn=true
# Ignore disabled targets (i.e iOS on Linux)
kotlin.native.ignoreDisabledTargets=true

org.jetbrains.compose.experimental.uikit.enabled=true

0 comments on commit d7d258e

Please sign in to comment.