Fix Spotless configuration #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Setting Kotlin target to "src/**/*.kt" is correct, but it breaks Spotless for the convention plugins. This part will be fixed soon and target reverted - Using multiple targetExclude is not supported, only the last call has any effect. This also means that calls to exclude buildDir didn't really do anything. And since there's no "bin" directory, removing both excludes - There are no Gradle Kotlin scripts under the src directories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"src/**/*.kt"is correct, but it breaks Spotless for the convention plugins. This part will be fixed soon and target revertedtargetExcludeis not supported, only the last call has any effect. This also means that calls to excludebuildDirdidn't really do anything. And since there's no"bin"directory, removing both excludessrcdirectories