Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for uuid, add clickable toggle #37

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tasinttttttt
Copy link

@tasinttttttt tasinttttttt commented Feb 4, 2023

  • Adds support for kirby3 UUIDS. No more relying on page url = freedom to change slugs. Breaking change though.
  • Add "clickable" toggle.

Resolves #21 and possibly #16

This is a breaking change as it changes the identifier to uuid. An honest tradeoff for a more robust method
@tasinttttttt tasinttttttt changed the title feat: add support for uuid, add clickable toggle feat: add support for uuid, add clickable toggle, fixes #21 Feb 4, 2023
@tasinttttttt tasinttttttt changed the title feat: add support for uuid, add clickable toggle, fixes #21 feat: add support for uuid, add clickable toggle, resolves #21 Feb 4, 2023
@tasinttttttt tasinttttttt changed the title feat: add support for uuid, add clickable toggle, resolves #21 feat: add support for uuid, add clickable toggle Feb 4, 2023
@tasinttttttt tasinttttttt changed the title feat: add support for uuid, add clickable toggle Add support for uuid, add clickable toggle Feb 4, 2023
@eXpl0it3r
Copy link

Works great, thank you! 🙂

Might want to update the example in the readme to use the uuid instead of the url.

@tinogithub
Copy link

tinogithub commented Oct 11, 2023

First, thank you for the idea.
However I am struggling on how to change my navigation bar links. How do I change this line i.e.?
<a href="<?php echo $child->url() ?>">
I expected to do
<a href="<?php echo $child->uuid()->url() ?>">

Every menu link now shows the corresponding UUID-link like "page://ArzOvYFUxVlEBFyu" but the page won't load after clicking.

Thank you for help


Solved it. This worked for me.
<a href="<?php echo page($child->uuid())->url(); ?>">

@afbora
Copy link
Collaborator

afbora commented Dec 8, 2023

What about uuid feature disabled from the config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use page id on Kirby links instead absolute url
4 participants