Add next/prev buttons to new Channel page. Save button now called 'Finish' #382
Conversation
There was a problem hiding this comment.
I love that you made this form feel more connected between the tabs, just added a couple thoughts and ideas.
Should we add an alert above these sections for new Channels that just says something like, "These settings can all be edited later"? When I create something new in a new platform I am always afraid I won't be able to go back and change some selection I make.
| @@ -156,7 +155,7 @@ export default function ChannelPropertiesEditor({ isNew }: Props) { | |||
| )} | |||
| /> | |||
| </Box> | |||
| <ChannelEditActions /> | |||
| {/* <ChannelEditActions /> */} | |||
There was a problem hiding this comment.
I think you meant to delete this
| ) | ||
| } | ||
| > | ||
| Finish |
There was a problem hiding this comment.
I've been tormented by the UX in this section, so hard to make it feel all connected and part of the same flow. I'm wondering if "finish" should be "Save & Exit" or something like that.
| </Button> | ||
| ) : null; | ||
| const nextButton = !isUndefined(channelEditorState.currentTab.next) ? ( | ||
| <Button onClick={() => onNav(channelEditorState.currentTab.next!)}> |
There was a problem hiding this comment.
Maybe we add startIcon arrows for the next/previous buttons to make it feel more connected?
…nish'
Cleaned up the way this works a bit -- using the custom context and moving the action buttons to the top level page instead of having to duplicate them.