Make php artisan api-key:delete actually delete
#127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API key passed to the command is found, and its existence is checked, but it is never actually revoked. Since the model uses SoftDeletes, we can use `$apiKey->delete()` to revoke the key. Note that this means the command doesn't actually support *deleting* the key unless the model has been replaced in the app config by a model class that doesn't support soft deletes. We could probably add a flag to specify that the command should use `->forceDelete()` instead, but I haven't opted to do so at this point, erring instead on the side of changing as little as possible. This PR adds the `->delete()` line so the artisan command will actually revoke the key.
|
Thanks for this @danhunsaker! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API key passed to the command is found, and its existence is checked, but it is never actually revoked. Since the model uses SoftDeletes, we can use
$apiKey->delete()to revoke the key. Note that this means the command doesn't actually support deleting the key unless the model has been replaced in the app config by a model class that doesn't support soft deletes. We could probably add a flag to specify that the command should use->forceDelete()instead, but I haven't opted to do so at this point, erring instead on the side of changing as little as possible.This PR adds the
->delete()line so the artisan command will actually revoke the key.