Skip to content

Commit

Permalink
msglist [nfc]: Add TODO(design) with unanswered question for date sep…
Browse files Browse the repository at this point in the history
…arator

In zulip#469 implementing date separators, Greg highlighted that the date
separator's deviation from web wasn't settled yet:
  zulip#469 (comment)
  zulip#469 (comment)
  • Loading branch information
chrisbobbe committed May 18, 2024
1 parent 86dcd80 commit a62b5f9
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions lib/widgets/message_list.dart
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,13 @@ class DateSeparator extends StatelessWidget {

final Message message;

// TODO(design) Do we want to match web more closely?
// - width of 1 logical pixel instead of 1 physical pixel
// - opacity 0.15
static const _line = BorderSide(
width: 0,
color: Colors.black);

@override
Widget build(BuildContext context) {
// This makes the small-caps text vertically centered,
Expand All @@ -534,9 +541,7 @@ class DateSeparator extends StatelessWidget {
child: DecoratedBox(
decoration: BoxDecoration(
border: Border(
bottom: BorderSide(
width: 0,
color: Colors.black)))))),
bottom: _line))))),
Padding(padding: const EdgeInsets.fromLTRB(2, 0, 2, textBottomPadding),
child: DateText(
fontSize: 16,
Expand All @@ -546,9 +551,7 @@ class DateSeparator extends StatelessWidget {
child: DecoratedBox(
decoration: BoxDecoration(
border: Border(
bottom: BorderSide(
width: 0,
color: Colors.black)))))
bottom: _line)))),
])),
);
}
Expand Down

0 comments on commit a62b5f9

Please sign in to comment.