-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fatal error: Cannot redeclare class RedisException in [snip]/lib/Redisent/Redisent.php #19
Comments
I get that too. |
Seems it doesn't like the friendly wrapped Exception handler in lib/Redisent/Redisent.php. If you comment out lines 15 and 16, then it'll run the demos without issue. |
I don't suppose you guys are using php-resque in combination with some sort of framework/library that's already creating its own RedisException class? I really hate how Redisent hasn't named the class Redisent_Exception - I might look at changing that. |
I have PHPRedis installed: https://github.com/nicolasff/phpredis |
Ah cool - I guess I'll rename the RedisException class to Redisent_Exception or similar then. |
we're using redisent for other stuff so was looking at setting php-resque to use the external lib. A quick look at commits seems to show that he has integrated most of the fixes you have implemented so might do a pull request for an exception rename. |
Any update on this? |
Hello, There was indeed, this commit should fix it: The issue was with the autoloader loading it twice. Hope thats helpful. On 1 Nov 2011, at 22:18, cj wrote:
Scott Wilcox @dordotky | scott@dor.ky | http://dor.ky |
I don't think this has been fixed yet, as long as /lib/Redisent/Redisent.php defines a RedisException class, it will still conflict with php-resque and break PHP. I'm all for renaming RedisException to RedisentException (or something similar), but at the very least can we wrap the class definition in a class_exists? i.e,
|
Still having the same issue here. I am also using php-redis in addition |
Above changes were merged in, which should fix this. Thanks! |
When downloading and running the demo's against the latest version of redis, I get the above titled exception.
Any ideas?
The text was updated successfully, but these errors were encountered: