Added enqueue failure detection #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a job fails to be enqueued, it would be useful to know it. So now Resque actually tells us whether the enqueue action was successful or if it failed. If your job ID comes back as FALSE, it didn't enqueue. Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
|
Hey Dan, Can you do me a favor and match the coding style used in the rest of php-resque? Happy to merge after. Cheers. |
|
Oops! On it. |
Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
|
How's that look? |
|
⛳ Thanks :) |
chrisboulton
added a commit
that referenced
this pull request
May 29, 2013
Added enqueue failure detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a job fails to be enqueued, it would be useful to know it. So now
Resque actually tells us whether the enqueue action was successful or
if it failed. If your job ID comes back as FALSE, it didn't enqueue.
Signed-off-by: Daniel Hunsaker danhunsaker@gmail.com