Let Resque_Worker::updateProcLine() use PHP 5.5's cli_set_process_title() if available

[richardkmiller]

updateProcLine() uses the PECL function setproctitle() if available. It should also try to use cli_set_process_title(), available in PHP 5.5.

cli_set_process_title() is preferred because setproctitle() is "incomplete and might lead to memory corruption on Linux". (See https://wiki.php.net/rfc/cli_process_title )

[danhunsaker]

Seems sound.

[danhunsaker]

On checking the code, it looks good as well, though I have a couple of comments which don't impact functionality.

Would it make sense to construct the title into a temporary variable prior to checking for either function, so we aren't duplicating code (and thereby forcing ourselves to maintain two separate lines of code identically if the title format ever changes for any reason)? Is this a valid application of DRY principles, or simply a tad overboard?

Why on earth is the else if form so common? PHP supports elseif as a single term, which inclines me to believe the latter to be more efficient, but I haven't honestly researched it. From what I can tell, though, it seems to simply be an artifact of working with other languages, particularly JavaScript - in my experience, devs who stay out of JS tend to use the single-word form.

[Rockstar04]

Looks great, but I would like to see the title built once and passed in as a variable like @danhunsaker was saying above.

[richardkmiller]

@danhunsaker @Rockstar04 I asked myself the same two questions when I wrote this code:

1. Should I use a temporary variable for the title, or is that overkill? Seeing as you both mentioned it, I think that sways me toward using one. I'll send an update.
2. Why "else if"? Good question. I assumed "else if" was a standard in this project because a quick global search produced 0 instances of "elseif" and ~12 instances of "else if". However, I prefer elseif and it's also in the PSR-2 standard. I could go either way for this patch -- whatever you guys want for this project.

[danhunsaker]

Picking nits, but now the indentation isn't consistent. >_> I blame selection of spaces over tabs.

Stupid maximum-fixed-width code lines.

[richardkmiller]

Ooops, my fault. Editor in the wrong mode.

[chrisboulton]

TIL cli_set_process_title is now a thing, and is now built in. : tada:

Thanks :)