Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bold ANSI code not supported #76

Closed
daveyarwood opened this issue Nov 11, 2019 · 7 comments
Closed

Bold ANSI code not supported #76

daveyarwood opened this issue Nov 11, 2019 · 7 comments

Comments

@daveyarwood
Copy link

daveyarwood commented Nov 11, 2019

I'm evaluating Colorizer to see if it can interpret ANSI escape codes in a Clojure REPL buffer, and I'm thrilled to see that it works for the most part! One thing I noticed is that the \e[1m (bold) escape code doesn't appear to be working. See my screenshots in Olical/conjure#53 (comment) (that post and the one above it) for context.

Here are a couple more screenshots, with and without colorizer enabled, so you can see the ANSI codes:

2019-11-11-162458_921x164_scrot

2019-11-11-162509_914x163_scrot

One thing that's interesting is that Vim prints a grayed-out ^[ where we would expect the escape character \e:

^[[1mExecuting:  ^[[1mtesting bold^[[1m...^[[0m

I think this is actually:

\e[1mExecuting:  \e[1mtesting bold\e[1m...\e[0m

which you can paste into your terminal (echo -e '\e[1mExecuting: \e[1mtesting bold\e[1m...\e[0m' Executing: testing bold...) and see that it's bold.

Great work on Colorizer, let me know if I can help with this in some way!

@chrisbra
Copy link
Owner

I believe bold isn't actually supported in a terminal.

@daveyarwood
Copy link
Author

I don't follow what you mean.

2019-11-15-100614_461x112_scrot

@chrisbra
Copy link
Owner

chrisbra commented Nov 15, 2019 via email

@daveyarwood
Copy link
Author

Surely it's possible? I'm not sure what is enabling this functionality, but whenever I write comments that contain words like TODO, or FIXME, Vim makes them bold:

2019-11-15-144546_267x81_scrot

(I also have Vim setup to make comments italic -- you can ignore that part)

@chrisbra
Copy link
Owner

chrisbra commented Nov 15, 2019 via email

@chrisbra
Copy link
Owner

I had some look, but this would involve getting the syntax element at the current cursor position and add the bold attribute to it. I don't think this is worth it.

chrisbra added a commit that referenced this issue Apr 17, 2022
related: #76
needs more work!
@chrisbra
Copy link
Owner

should be there now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants