-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support post update hook for UnicodeDownload #16
Comments
Hi Evan! On Mi, 15 Jun 2016, Evan Sosenko wrote:
I don't know vim-plug very well. I would either force sourcing the Best, ChristianGlück ist Selbstgenügsamkeit. |
IMO, force sourcing the file goes against the grain of using a plugin manager (path resolution is non-trivial). Trying that does run the command, however it has the same issue as just calling It would be nice if the Download function could work with this, but a workaround is let unicode_src = 'http://unicode.org/Public/UNIDATA/UnicodeData.txt'
let unicode_dest = './autoload/unicode/UnicodeData.txt'
Plug 'chrisbra/unicode.vim',
\ { 'do': join(['curl --create-dirs -o', unicode_dest, unicode_src], ' ')} |
downloading depends on netrw. Perhaps that is not initialized, when vim-plug runs? Anyhow, I think this is more a question for @junegunn and how to use vim-plug |
Yeah, it is. After the initial clone, vim-plug executes Anyway, in this case you can load the plugin in advance using function! DoUnicode(arg)
call plug#load('unicode.vim')
UnicodeDownload
endfunction
Plug 'chrisbra/unicode.vim', { 'do': function('DoUnicode') } But as you have noted, the way the command works is not compatible with the subsequent buffer manipulation of vim-plug. The part of the installer was written with the assumption that the cursor stays in its window. It'll be an easy fix, I'll look into it later in the day. |
Thanks @junegunn for the info. I am closing this then. |
@razor-x Should be fixed now.
I found that |
@junegunn Right, @chrisbra Perhaps I should open a new issue for this, but basically For reference, I'm using Neovim. |
I'll fix that. The second bug you mentioned, I haven't seen, can you check, if this happens with Vim as well please? |
Yes, the popup bug happens in vim and gvim as well. The popup is unfocused as well as stuck open. |
The popup bug is a Vim bug. I have posted a patch. Let's hope it will get fixed soon. |
@razor-x With the latest vim-plug, you can now do this (note the Plug 'chrisbra/unicode.vim', { 'do': ':silent! UnicodeDownload' } |
Am 2016-07-13 16:10, schrieb Junegunn Choi:
Great, thanks! Note: the sil! shouldn't be necessary anymore with the latest version of Best, |
I'd like the download of
UnicodeData.txt
to happen on plugin install / update. I'm trying this with vim-plug:which fails with
I also tried
which seems to run, but not actually download anything and breaks the vim-plug install process.
The text was updated successfully, but these errors were encountered: