de-indent correctly after typing 'fi' #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression from ef2e050 "Better indenting for nested if sections" which changed to using searchpair() instead of search(). When typing "fi", the cursor is after the start of the \<fi\> match, so vim un-indents back to the next outer if/fi block rather than the expected block. The help for searchpair() suggests "When searching backwards and {end} is more than one character, it may be useful to put "\zs" at the end of the pattern, so that when the cursor is inside a match with the end it finds the matching start." Follow this suggestion to restore the expected behavior. Fixes: chrisbra#15
chrisbra
added a commit
that referenced
this pull request
Apr 28, 2019
Currently fails, will be activated, once PR #16 is included
|
Thanks, I have included your patch and amended it a bit to include a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from ef2e050 "Better indenting for nested if sections" which
changed to using searchpair() instead of search().
When typing "fi", the cursor is after the start of the <fi> match, so
vim un-indents back to the next outer if/fi block rather than the
expected block.
The help for searchpair() suggests "When searching backwards and {end} is
more than one character, it may be useful to put "\zs" at the end of the
pattern, so that when the cursor is inside a match with the end it finds
the matching start." Follow this suggestion to restore the expected
behavior.
Fixes: #15