Rename ChainRulesCore differential types #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 4, 2021 18:52
|
I'm really not up to speed on |
|
Certainly! Looks like the tests don't quite pass yet. |
|
We use quite an old version of Line 13 in 1b95455 which uses the old nomenclature AFAICT, so this clashes with the version of ChainRulesCore. Maybe all that needs changing is that version bound?
|
|
Oh, there's a few things, will take a look today |
mzgubic
commented
Jun 11, 2021
sethaxen
approved these changes
Jun 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to JuliaDiff/ChainRulesCore.jl#358, JuliaDiff/ChainRulesCore.jl#353, and JuliaDiff/ChainRulesCore.jl#365