allow override of the no permissions view #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #440
This PR adds an
EXPLORER_NO_PERMISSION_VIEWconfiguration option. Library consumers can set this to render custom view when users does not have permission to view a page within explorer. If the option is not set, the existingSafeLoginViewis used.The library consumer can simply return a redirect from that view, or, they can handle logged in and anonymous users differently.
The option is a view path (e.g.
consumerapp.mymodule.myfiewfunc), and the custom view has to be function based. This required wrapping the class basedSafeLoginView. Let me know if you'd like this done differently, we're happy to implement it however you think would best fit with the app.