Translates expression for duration #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes incorrect translation of expression with blocktrans introduced in PR #345. Django docs show that expressions must be bound to a variable before being used inside a blocktrans (now blocktranslate since 3.1) https://docs.djangoproject.com/en/2.2/topics/i18n/translation/#blocktrans-template-tag
This newer format is easier to read, and available since at least django 1.8.
|
@jtrain Thank you for your contribution. Is this basically django 2.2+ compatible? |
|
I haven't had to make any other changes on django 3.2, its working very nicely. If you are asking if this specific change is compatible with 2.2+ then yes, in fact it is 1.8+ compatible. |
|
Here are the docs for 1.8 blocktrans https://docs.djangoproject.com/en/1.8/topics/i18n/translation/#blocktrans-template-tag, I used this syntax. |
|
Fantastic - Thank you @jtrain! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am running django 3.2 and noticed that the execution time is blank. e.g.
https://docs.djangoproject.com/en/2.2/topics/i18n/translation/#blocktrans-template-tag
The django docs are clear that expressions should be bound to a local variable before being used inside the translation tag.
I've chosen to use the
older format for the expression binding since this should cover a wider range of django installsnewer format because it is also available for a wide range of django installs.