Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #483 #484

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Fix for #483 #484

merged 2 commits into from
Aug 29, 2022

Conversation

spapas
Copy link
Contributor

@spapas spapas commented Aug 29, 2022

I actually had to create the PR because I needed to use that instead of the pypi release on my requirements to avoid the bad migration.

@marksweb
Copy link
Collaborator

Thanks @spapas, I thought this was in already 🤦

@marksweb
Copy link
Collaborator

@spapas could you please add this to the unreleased section in the history file please?

@spapas
Copy link
Contributor Author

spapas commented Aug 29, 2022

@marksweb done (sorry but I couldn't make the link to the PR work)

@marksweb
Copy link
Collaborator

@marksweb done (sorry but I couldn't make the link to the PR work)

No problem - I can do that. For reference, the link locations are all at the end of the file and then they just get the syntax added to get them to use that location.

@spapas
Copy link
Contributor Author

spapas commented Aug 29, 2022

Ah!!! I thougth that this was some github magic... Yes I only now noticed the .rst extension :) Thank you!

@marksweb marksweb merged commit 241a0a5 into chrisclark:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants