Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export assistant models #618

Merged
merged 2 commits into from
May 14, 2024

Conversation

MartingaleCoda
Copy link
Contributor

Fixes issue where python manage.py makemigrations expects PromptLog model to be deleted, as the explorer app doesn't include it in its models.py file.

Example of the issue when moving from 4.0.2 to 4.2.0:

python3 manage.py makemigrations --check
Migrations for 'explorer':
  /opt/venv/lib/python3.9/site-packages/explorer/migrations/0016_delete_promptlog.py
    - Delete model PromptLog

Issue 615 may be related.

@chrisclark
Copy link
Owner

Ahh, that makes sense. Thanks so much for clarifying. Yeah I'll bet that is source of the issue in #615. I'll have to figure out why I didn't catch it in testing...

Will get this into a point release.

@MartingaleCoda
Copy link
Contributor Author

Sounds good.

I don't think you need the explorer/assistant/__init__.py change I put in this pull request since you don't keep models as a folder instead of a file. I think the only important part is that the models for the explorer app include the models in the assistant module.

Have a good weekend! =)

@chrisclark chrisclark merged commit c0f55b6 into chrisclark:master May 14, 2024
9 checks passed
@chrisclark
Copy link
Owner

Merged. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants