Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several deprecation warnings in pandas 2.1 which became actual errors in 2.2 #158

Merged
merged 2 commits into from Mar 26, 2024

Conversation

bixbyr
Copy link
Contributor

@bixbyr bixbyr commented Feb 1, 2024

Fix for #156 in response to several minor pandas api changes. Tested with Django 4.2.9 and pandas 2.1.0.

…rors in 2.2. Also updated several test cases to use iloc when comparing results.
@chrisdev
Copy link
Owner

chrisdev commented Feb 5, 2024

Thanks @bixbyr some tests are failing. I I think we can ignore the Python 2.7 but apparently the for newer versions the pandas the testing module has been deprecated so we need to do our own makeTimeDataFrame

@jayvdb
Copy link

jayvdb commented Mar 5, 2024

ping @bixbyr , will you be able to do the extra work requested by @chrisdev to get the CI to pass?

… non-public method which was removed. This was done by just taking the parts we needed. Also fixed a couple formatting issues which violate python style guides.
@bixbyr
Copy link
Contributor Author

bixbyr commented Mar 7, 2024

I added a commit which fixes the things which broke in 2.2. The moral of the story is don't rely on non-public parts of pandas. I think my pull request is correctly updated with 2 commits now instead of 1? I've never actually tried committing to a public repo before, weird as that sounds :)

Hopefully the maintainer can decide if we pass the tests now, and if the day has come to deprecate support for python 2 and pandas < 1.0 because seriously.

@chrisdev
Copy link
Owner

@bixbyr sorry for taking so long to respond. Was down with COVID! I thought this thing had gone away but its still around Still recovering so give me a few days.
Yes I think we should just deprecate support for python 2. Although last time I tried to do so there was a bit of an uproar. But think this time it goes!

@bixbyr
Copy link
Contributor Author

bixbyr commented Mar 19, 2024

Any updates? Will this be approved and a new version released?

@chrisdev chrisdev merged commit d3aba86 into chrisdev:master Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants