trying an imediate empty 200 to kill timeout errors in slack

chrisdevwords · Aug 15, 2017 · e7e091b · e7e091b
1 parent afa8ca6
commit e7e091b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 13 deletions.
diff --git a/src/index.js b/src/index.js
@@ -24,7 +24,7 @@ function handler(event, context, callback) {
         response_url
     } = parseFormString(body);
 
-    console.log('PROCESSING SLACK COMMAND', text, response_url, SPOTIFY_RADIO_PLAYLIST)
+    //console.log('PROCESSING SLACK COMMAND', text, response_url, SPOTIFY_RADIO_PLAYLIST)
 
     if (token !== SLACK_TOKEN) {
         callback(null,
@@ -42,15 +42,11 @@ function handler(event, context, callback) {
                 extractFromUri(trackUri, 'track'),
                 SPOTIFY_USER_ACCESS_TOKEN
             )
-            .catch((error) => {
-                console.log(error);
-                callback(null,
-                    slack.slackResp(error.message)
-                );
-            })
             .then((trackInfo) => {
-                callback(null,
-                    slack.slackResp(radio.SLACK_PENDING_MESSAGE(trackInfo))
+                slack.notify(
+                    response_url,
+                    radio.SLACK_PENDING_MESSAGE(trackInfo),
+                    slack.TYPE_PRIVATE
                 );
                 radio
                     .playBasedOnTrack(
@@ -60,22 +56,31 @@ function handler(event, context, callback) {
                         SPOTIFY_LOCAL_URL
                     )
                     .then((msg) => {
-                        console.log('notify success', response_url, msg);
+                        //console.log('notify success', response_url, msg);
                         slack.notify(
                             response_url,
                             msg
                         );
                     })
                     .catch(({ message }) => {
-                        console.log('notify error', response_url, message);
+                        //console.log('notify error', response_url, message);
                         slack.notify(
                             response_url,
                             `Error creating playlist: ${message}`,
                             slack.TYPE_PRIVATE
-                        )
+                        );
                     });
+            })
+            .catch((error) => {
+                slack.notify(
+                    response_url,
+                    error.message,
+                    slack.TYPE_PRIVATE
+                );
             });
 
+        callback(null, slack.slackResp(''));
+
     }
 }
 

diff --git a/test/test_index.js b/test/test_index.js
@@ -61,7 +61,7 @@ describe('The Index Lambda Handler', () => {
             artist: 'Cardi B',
             id: '2771LMNxwf62FTAdpJMQfM'
         };
-        const respMsg = radio.SLACK_PENDING_MESSAGE(trackInfo);
+        const respMsg = ''; //radio.SLACK_PENDING_MESSAGE(trackInfo);
 
         beforeEach(() => {
            sinon