captureStackTrace if error object is passed but err.stack is undefine…

…d, this happens f.e. in case of RangeError
chrisdickinson · May 23, 2012 · 6cca37b · 6cca37b
1 parent 87732f0
commit 6cca37b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "author": "Chris Dickinson <chris@neversaw.us> (http://neversaw.us/)",
   "name": "tracejs",
   "description": "Expand Error.stack traces into usable objects providing context and highlighting",
-  "version": "0.1.4",
+  "version": "0.1.5",
   "homepage": "http://github.com/chrisdickinson/tracejs/",
   "repository": {
     "type": "git",

diff --git a/trace.js b/trace.js
@@ -152,7 +152,7 @@ Frame.prototype.toString = function() {
 };
 
 Frame.prototype.get_lines = function(context, ascii_cursor, highlight_error_start) {
-  context = context || 0; 
+  context = context || 0;
   filedata = this.filedata().split('\n');
 
   var start_line = this.line - context - 1,
@@ -194,10 +194,11 @@ Frame.prototype.get_lines = function(context, ascii_cursor, highlight_error_star
   return lines.join('\n');
 };
 
-var trace = function(err) {
+var trace = function trace(err) {
-  if(!err) {
+  err || (err = {});
-    err = {};
+
-    Error.captureStackTrace(err);
+  if (!err.stack) {
+    Error.captureStackTrace(err, trace);
   }
 
   var lines = err.stack.split('\n'),