Add NSLondon February and March 2016 #108
Conversation
|
There seems to be some kind of CI issue, but I don't think it's your code... I think we'll need to fix that first. On 13-04, Douglas Hill wrote:
|
| NSLondon February 2016: | ||
| - language: English | ||
| speakers: [Raimon Lapuente, Gergely Orosz] | ||
| title: "Sorry Objc: It’s not you, it’s me" |
There was a problem hiding this comment.
https://travis-ci.org/chriseidhof/pomotv/builds/122938451#L2552
The build fails because the path generated for this video is build/events/nslondon/february-2016/gergely-orosz-raimon-lapuente-sorry-objc-it?s-not-you-it?s-me.html. The curly closing quotation marks, ’, are being turned into ?, which not allowed in URL paths.
I don’t know why the name is being processed like this. Compare these two, which have : and ’, and are wrapped in ":
title: "Sorry Objc: It’s not you, it’s me"
title: "Let’s Play: Refactor the Mega-Controller"
The second is working: it is processed into build/events/nsspain/2015/andy-matuschak-let’s-play-refactor-the-mega-controller.html
There was a problem hiding this comment.
I can recreate the failure locally with bundle exec middleman build --clean. I didn’t find this when I initially made the PR because I just used bundle exec middleman — and in that case I don’t think you see the problem unless you try to view a single video page, and I think the only way to do this is via search.
There was a problem hiding this comment.
@chriseidhof Any ideas on this? While it would be nice to identify and fix the problem, if you think fixing is out-of-scope I can change the name to use straight quotation marks ' instead of proper ones ’.
There was a problem hiding this comment.
Sorry for the late reply @douglashill !
I think we should probably strip those characters when we generate the page names...
The code for that is in source/lib/video_helpers.rb. I think it's line 24. Do you have time to update the PR for this?
There was a problem hiding this comment.
I had a little look but I am not familiar with the Ruby/middleman debugging tools, or really any part of the stack. I made #112 to track this. I suppose there’s no pressing need to fix it now. I’m not going to look into this further at the moment.
For now, I used straight quotes for the title causing the problem and rebased onto master, so we can get these videos up. 😄
douglashill
force-pushed
the
nslondon-march-2016
branch
from
063454c
to
66e9985
Compare
|
Rebased to resolve conflicts and added NSLondon April. |
|
Awesome, thanks @douglashill |
No description provided.