Fixing positioning issue #873
Conversation
|
@scottdavis can you review and merge when convenient? |
| @@ -1,3 +1,5 @@ | |||
| require 'rational' | |||
There was a problem hiding this comment.
Nope, it just happened that my commit contained these changes and I created a pull request from it. You only need to change layout_methods.rb
There was a problem hiding this comment.
manually changing something kinda makes using pull requests pointless =p
|
@scottdavis what's the status here? Are you holding this up so that a single require can be removed? >_< |
|
No I'm holding it up because I'm busy I'll get to it this week I'm going to cherry-pick it into master Sent from my iPhone On Jun 4, 2012, at 2:28 AM, Chris Eppsteinreply@reply.github.com wrote:
|
|
merged 5e42b8f |
When there are some repeat-x images in the sprite and some other images have position set to 100%, there is a gap between sprite's right side and images with position = 100% (because width-fix was applied after they had been positioned).
I tried to figure out how to write a test for such case and I must say that your tests are difficult to comprehend ;)