Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement !new and !join #19

Closed
chrisgillis opened this issue Dec 23, 2015 · 4 comments
Closed

Implement !new and !join #19

chrisgillis opened this issue Dec 23, 2015 · 4 comments

Comments

@chrisgillis
Copy link
Owner

After playing a lot in Slack, it seems like it would be better if we moved more to a 'i want to start a new game, everyone !join it' rather than '!start @user1 @user2 @user3' or '!start' (rarely everyone is at keyboard)

I want to move to a system that looks more like this

Usage: !new
@me: !new Classic 6
@user1: !join
@Werewolf-Bot: Classic 6 players: @user1
@user2: !join
@Werewolf-Bot: Classic 6 players: @user1,@user2
@user3: !new Classic 4
@Werewolf-Bot: Lobby already in progress.
@me: !start
@Werewolf-Bot: Not enough players to start yet.
@me: !end
@Werewolf-Bot: Game cancelled.

@ThatOneGuyDotNet
Copy link
Contributor

partially Implemented in #26
The game types/number of players is not implemented, you create a !new lobby, people !join it, then you !start it. The ability to specify the game type/players should be done at the same time as it is done for #4.

Also changed the default '!start' for an entire room to '!start all' because even before this change people were starting whole room games when they didn't mean to.

@chrisgillis
Copy link
Owner Author

Yeah after all your changes this could actually be implemented in !setoption

@ThatOneGuyDotNet
Copy link
Contributor

I guess I don't see what you mean. The way I implemented it still allows the same functionality without adding another option. Sure some people that use the current !start command might have to re-learn to change it to '!start all'. We could change the !start command to be smart enough to sense that no parameters were passed and a lobby isn't started and return a message like "A lobby has not been created, use !new to start a new lobby that players can !join. You can also use !start all to start a game with all players in the room or !start @user1 @user2 @user3 to start a game with the provided players."

Thoughts?

@chrisgillis
Copy link
Owner Author

Oops, take my comment and imagine it was on #4 instead :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants