Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay not working because wrong attribute #3

Closed
mxmihai opened this issue Dec 9, 2021 · 3 comments
Closed

Delay not working because wrong attribute #3

mxmihai opened this issue Dec 9, 2021 · 3 comments

Comments

@mxmihai
Copy link

mxmihai commented Dec 9, 2021

Maybe the delay shoule be more flexible.

instead of:

    let delayOrAutohide = opts.delay ? `data-delay="${opts.delay}"` : `data-autohide="false"`;

maybe:

    let delayOrAutohide = opts.delay ? `data-delay="${opts.delay}"` : `data-bs-autohide="false"`;
@mxmihai mxmihai changed the title Delay more flexible Delay not working because wrong attribute Dec 9, 2021
@mxmihai
Copy link
Author

mxmihai commented Dec 9, 2021

also, instead of:

delayOrAutohide = `data-autohide="false"`;

it should be:

delayOrAutohide = `data-bs-autohide="false"`;

@mxmihai
Copy link
Author

mxmihai commented Dec 9, 2021

also, instead of:

if ($.toastDefaults.pauseDelayOnHover) {

it shoudl be:

if ($.toastDefaults.pauseDelayOnHover && opts.delay) {

@chrisgo
Copy link
Owner

chrisgo commented Mar 16, 2022

@mxmihai thank you for hunting this down, I was just getting back to this and found these problems and you already got the code ready :)

In addition to the items here (plus #1 and #2), also fixed 2 more

  • the positioning position-absolute needed to be position-fixed in the toast-container
  • data-delay is now data-bs-delay

@chrisgo chrisgo closed this as completed Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants