Option grep #14
Open
Option grep #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @altherlex ! Thanks for your contribution. I think it could be better to fix the :regexp option already present to work for filtering full paths, although it would break backwards compatibility. Perhaps the new option could be a flag to intruct filtering to work on full paths, keeping the default as it is, filtering only on file's basename. Note that the :regexp option is only available as an instance configuration options, not as a command line option for the executable. |
| @@ -36,6 +36,10 @@ opt_parser = OptionParser.new do |opt| | |||
| options[:s3_secret] = s3_secret | |||
| end | |||
|
|
|||
| opt.on("-g s","--grep *xml","set specific file or specific type files. Default: **/* recursive mode") do |filter| | |||
There was a problem hiding this comment.
The short and long option must be defined as "-g PATTERN" and "--grep PATTERN", and then use PATTERN in the description. Eg.: "Filter full file paths using PATTERN as the regular expression"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options to grep files to upload
s3uploader -d home/grade -t 4 -g *.js /home/grade espn-api-importer