URL escape GitHub username

chrishunt · Oct 25, 2013 · 12d77d6 · 12d77d6
1 parent 3435640
commit 12d77d6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/github/auth/keys_client.rb b/lib/github/auth/keys_client.rb
@@ -1,3 +1,4 @@
+require 'cgi'
 require 'httparty'
 
 module Github::Auth
@@ -21,7 +22,7 @@ def initialize(options = {})
       options = DEFAULT_OPTIONS.merge options
       raise UsernameRequiredError unless options.fetch :username
 
-      @username = options.fetch :username
+      @username = CGI.escape(options.fetch :username)
       @hostname = options.fetch :hostname
     end
 

diff --git a/spec/unit/github/auth/keys_client_spec.rb b/spec/unit/github/auth/keys_client_spec.rb
@@ -33,6 +33,11 @@
       keys_client = described_class.new username: username
       expect(keys_client.username).to eq username
     end
+
+    it 'url escapes the username' do
+      keys_client = described_class.new username: 'spaces are !o.k.'
+      expect(keys_client.username).to eq 'spaces+are+%21o.k.'
+    end
   end
 
   describe '#keys' do