Skip to content

Commit

Permalink
Use Hi::Logger in App and Server
Browse files Browse the repository at this point in the history
  • Loading branch information
Chris Hunt committed Jan 4, 2014
1 parent 38ffdf6 commit 12af39b
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 17 deletions.
21 changes: 10 additions & 11 deletions lib/hi/app.rb
Original file line number Diff line number Diff line change
@@ -1,29 +1,28 @@
require 'awesome_print'
require 'hi/request'
require 'hi/logger'

module Hi
class App
attr_reader :port
attr_reader :port, :logger

DEFAULT_PORT = 3000

def initialize(port = nil)
def initialize(port = nil, logger = Hi::Logger.new)
@port = (port = port.to_i) > 0 ? port : DEFAULT_PORT
@logger = logger
end

def call(env)
log Hi::Request.new(env).to_h
request = Hi::Request.new(env).to_h

log "#{request[:request_method]} #{request[:url]} (#{Time.now})"
log request

[ 200, { 'Content-Type' => 'text/plain' }, ['hi'] ]
end

private

def log(request)
unless ENV['RACK_ENV'] == 'test'
ap "#{request[:request_method]} #{request[:url]} (#{Time.now})"
ap request
end
def log(message)
logger.log message
end
end
end
8 changes: 2 additions & 6 deletions lib/hi/server.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ def initialize(app)
end

def start(port = app.port, attempts = 1)
log "Starting server on port #{port}...\n\n"
app.log "Starting server on port #{port}...\n\n"
start! port
rescue RuntimeError => e
if attempts < MAX_ATTEMPTS
log "\nUnable to start server, trying random port instead."
app.log "\nUnable to start server, trying random port instead."
start random_port, attempts + 1
else
raise CantStartServerError.new(e)
Expand All @@ -33,9 +33,5 @@ def start!(port)
def random_port
1000 + Random.rand(9000)
end

def log(message)
puts message unless ENV['RACK_ENV'] == 'test'
end
end
end

0 comments on commit 12af39b

Please sign in to comment.