[improve: code coverage] ColorControl.js #81
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: https://github.com/times/cardkit/issues/61
Basically, this PR just added tests to
ColorControl.js
based on its original implementation,I mean, it never adds any feature or functionality and is tiny improvement about coverage.
There is no real reason for starting with
ColorControl
.Anyway...
Writing tests of
ColorControl
gave me 3 ideas.ColorControl
to have a validator forlayer
prop.ColorControl
virtually requireslayer.editable
property but it is implicative.layer.editable
to have consistency in terms of type.layer.editable[name]
accepts object, string and boolean and it defines DOM content ofColorControl
. I suspect this is complicated.editable: {picker: 'circle', options: [...]}
=>CirclePicker
editable: {picker: 'chrome'}
=>ChromePicker
editable: {picker: 'input'}
=>input tag
ColorControl#handleChange
should validate an argument.If you are favor of even one of the ideas, I am willing to implement it (them) in next PR.
Thanks for reading.