Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licensing concerns #34

Closed
zerogerc opened this issue Apr 8, 2022 · 6 comments
Closed

Licensing concerns #34

zerogerc opened this issue Apr 8, 2022 · 6 comments

Comments

@zerogerc
Copy link

zerogerc commented Apr 8, 2022

Hi, thanks for the awesome library.

Is there any way to remove python-Levenshtein from the dependencies? It's licensed under GPLv2 which is not compatible with MIT of errant.

@chrisjbryant
Copy link
Owner

This wasn't something I was aware of - thanks for letting me know!

I'll look into using an alternative, but in the meantime, you can try python's difflib.SequenceMatcher which is what ERRANT v2.1.0 relied on before python-Levenshtein.

@zerogerc
Copy link
Author

Thanks a lot, I'll take look.

@chrisjbryant
Copy link
Owner

I should probably add that difflib.SequenceMatcher was ~3x slower than python-Levenshtein (which is why I changed it in the first place) so don't be surprised if you take a performance hit. At least it gets around the licensing issue though.

@chrisjbryant
Copy link
Owner

As a follow-up, I also found out that the RapidFuzz package should be a good alternative (MIT license), which should also be faster than python-Levenshtein so I'll look at officially adding that at some point!

@chrisjbryant
Copy link
Owner

Just pushed ERRANT v2.3.1 which now uses RapidFuzz instead of python-Levenshtein so the licensing conflict is resolved!

@zerogerc
Copy link
Author

Great news. Thanks a lot for the help!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants