-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code refactor, setup.py, auto-formatting #7
Conversation
Thanks again for all of this. I don't want to release it during the shared task as it might confuse people, but will certainly take a look and do some testing afterwards, probably April. Hope you can wait! |
@chrisjbryant Cool, btw Spacy 2.1 released today https://explosion.ai/blog/spacy-v2-1 , so we can release a v1.0.1 with spacy 2.1 I guess. |
Fyi, Spacy 2.1.2 finally changed the POS mappings so I'd definitely have to revisit the rules to be compatible with spacy 2.1. Cf. explosion/spaCy#3455. |
@chrisjbryant A gentle reminder. If there is anything to be done my side, will do. |
Yep, it's on my to-do list! The shared task finished last week and we're releasing the official results tomorrow so I still have a bit to do. |
Awesome, Our team has a submission going there in the shared task 😀 . We can release multiple versions probably the 1.0.0 with official scorer and 1.1.0 with updated spacy. Or if you can adapt the setup.py and the scaffolding code to existing code without all these other changes, that can be 1.0.0. |
Awkward question: how easy is it to get rid of all the explicit typing? |
I guess they can be removed by a simple regex or some find and replace .. Will check if there is any automated way to remove them. I thought people generally used virtualenvs, but yeah for backward compatibility we can move types to comments for typepchecker to still function. |
Sorry to resurrect this, but we'd love to help make ERRANT pip-installable, ideally as a module, so it can be called from within Python. I was under the same impression about version restrictions, but it turns out older version of Python can support typing, similar to how This stackoverflow answer discusses how you can support type syntax with Python 3.0-3.4 (3.5+ already have So to make progress on this PR, I propose:
@chrisjbryant , if you can tell me more about 2, I am happy to help. Also, if 1 were completed as described, would you feel that there is adequate backwards compatibility? |
It took 9 months, but I finally found the time to learn setup.py and refactor everything (inspired by this pull request)! |
errant parallel_to_m2
etc to get the job done.