move to esp32 standard logging style #130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced Serial.print*() style logging with log_*() style logging
resolves #129
Thank you for creating a pull request to contribute to esp32OTA GitHub code!
Before you open the request please review the following guidelines and tips to
help it be more easily integrated:
of the code were modified. This will help us understand any risks of integrating
the code.
All references to
Serial.print()
,Serial.printf()
andSerial.println()
have been replaced withlog_e()
,log_w()
etc style ESP32 logging.doesn't apply to a supported platform of the library please mention it.
I did not change the default progress callback which prints dots to the Serial Console
strive to not break users of the code and running tests/examples helps with this
process.
I have tested the library against my project that uses the library. I have not tested it against all of the examples in this repo.
Thank you again for contributing! We will try to test and integrate the change
as soon as we can, but be aware we have many GitHub repositories to manage and
can't immediately respond to every request. There is no need to bump or check in
on a pull request (it will clutter the discussion of the request).
Also don't be worried if the request is closed or not integrated--sometimes the
priorities of esp32OTA's GitHub code (education, ease of use) might not match the
priorities of the pull request. Don't fret, the open source community thrives on
forks and GitHub makes it easy to keep your changes in a forked repo.
After reviewing the guidelines above you can delete this text from the pull request.