Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to esp32 standard logging style #130

Merged
merged 1 commit into from
May 25, 2023
Merged

move to esp32 standard logging style #130

merged 1 commit into from
May 25, 2023

Conversation

webmonkey
Copy link
Contributor

replaced Serial.print*() style logging with log_*() style logging

resolves #129

Thank you for creating a pull request to contribute to esp32OTA GitHub code!
Before you open the request please review the following guidelines and tips to
help it be more easily integrated:

  • Describe the scope of your change--i.e. what the change does and what parts
    of the code were modified.
    This will help us understand any risks of integrating
    the code.

All references to Serial.print(), Serial.printf() and Serial.println() have been replaced with log_e(), log_w() etc style ESP32 logging.

  • Describe any known limitations with your change. For example if the change
    doesn't apply to a supported platform of the library please mention it.

I did not change the default progress callback which prints dots to the Serial Console

  • Please run any tests or examples that can exercise your modified code. We
    strive to not break users of the code and running tests/examples helps with this
    process.

I have tested the library against my project that uses the library. I have not tested it against all of the examples in this repo.

Thank you again for contributing! We will try to test and integrate the change
as soon as we can, but be aware we have many GitHub repositories to manage and
can't immediately respond to every request. There is no need to bump or check in
on a pull request (it will clutter the discussion of the request).

Also don't be worried if the request is closed or not integrated--sometimes the
priorities of esp32OTA's GitHub code (education, ease of use) might not match the
priorities of the pull request. Don't fret, the open source community thrives on
forks and GitHub makes it easy to keep your changes in a forked repo.

After reviewing the guidelines above you can delete this text from the pull request.

replaced Serial.print*() style logging with log_*() style logging

resolves #129
@chrisjoyce911 chrisjoyce911 merged commit 2bbc9cb into chrisjoyce911:master May 25, 2023
3 checks passed
@webmonkey webmonkey deleted the logging branch May 25, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging is a mixture of Serial.print* and log_*()
2 participants