Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type mismatch in error reporting #133

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

raomin
Copy link
Contributor

@raomin raomin commented Jul 16, 2023

There is a type mismatch in the reporting of an update failure here

getError() returns an uint8

    uint8_t getError(){ return _error; }

but it's expecting a char*

        log_e("An Update Error Occurred. Error #: %s", F_Update.getError());

If called, this crashes the esp32 as printf would try to access the uint8 as address for a char[].

This PR is to replace the line of log to:

        log_e("An Update Error Occurred. Error #: %d", F_Update.getError());

Thanks

@chrisjoyce911 chrisjoyce911 merged commit facd0ee into chrisjoyce911:master Jul 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants