Using LittleFS and improving semver.c to fix some compiler's warning
#91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using LittleFS and Minor bug fixes for compiler's warning
|
bump Please have a look at #92 as it implements your semver fix along with agnostic filesystem handling. Provided the <SPIFFS.h>, <LittleFS.h> or <SD.h> library is included before including <esp32fota.h>, and the chosen filesystem is properly started in your Optional declarations eventually allow hybrid situations, like storing the signature on the SD and certificate in flash memory. There's an open discussion about this. |
|
Closing this as implemented in 0.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear chrisjoyce911: Thank you for your useful esp32FOTA library. I would like to added some minor improvements and bug fixes as following:
semver/semver.cto eliminate the Compiler's warnings: e.g.warning: passing argument 3 of 'concat_num' discards 'const' qualifier ...Know limitations:
Tested:
I hope and believe that the above improvements is useful for future users of this library and that change not break any API of your library. Thank you for you time!