Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix image reference clashes in rst #90

Merged
merged 3 commits into from
Jul 9, 2019
Merged

fix image reference clashes in rst #90

merged 3 commits into from
Jul 9, 2019

Conversation

chrisjsewell
Copy link
Owner

No description provided.

fixes #88 

If an image is set without a caption (e.g. `![](image.png)`), then pandoc will assign an iterative reference identifier to it:

```
|image0|

.. |image0| image:: image.png
```

However, this iterator restarts for each markdown cell, which can lead to reference clashes. Therefore we specifically assign the identifier here, as its url

```
|main_files/example1.png|

.. |main_files/example1.png| image:: main_files/example1.png
```

* flake8 fixes
@chrisjsewell chrisjsewell merged commit 707d239 into master Jul 9, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 78.529% when pulling 844390d on develop into db99c84 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants