fix all typescript compile errors #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
right now i've only did a few workarounds for non existing properties as well as some proper type declaration todos should be added to all dot-notation eslint inline rule exceptions since those are actually typescript errors of non existing properties a few ts-ignore statements where added in places where it wasn't easily possible to cast to a generic type, descriptions why those are done are added in the comments
…t lose track on the changes
chriskalmar
requested changes
Jun 6, 2021
|
Btw, good call on the todos. 🤘 |
|
test ran successfully on my machine, please run them through GH actions again to verify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a first draft to "fix" all kind of compile errors
right now i've only did a few workarounds for non existing properties as well as some proper type declaration
todos should be added to all dot-notation eslint inline rule exceptions since those are actually typescript errors of non existing properties
a few ts-ignore statements where added in places where it wasn't easily possible to cast to a generic type, descriptions why those are done are added in the comments