Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed types in all tests #224

Merged
merged 3 commits into from
Jun 7, 2021
Merged

fixed types in all tests #224

merged 3 commits into from
Jun 7, 2021

Conversation

Enubia
Copy link
Contributor

@Enubia Enubia commented Jun 7, 2021

this pr should fix all types in every testcase that was previously throwing a compile error due to type miss matching

local tests passed but i wasn't able to test the integration tests so please run them through GH actions to see if everything still works properly

this pr should fix all types in every testcase that was previously throwing a compile error due to type miss matching

local test passed but i wasn't able to test the integration tests so please run them through GH actions to see if everything still works properly
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2021

Codecov Report

Merging #224 (b0ef413) into master (93935cc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   83.53%   83.53%           
=======================================
  Files          85       85           
  Lines        6231     6231           
  Branches     1139     1139           
=======================================
  Hits         5205     5205           
  Misses        993      993           
  Partials       33       33           

@chriskalmar chriskalmar merged commit 4e72de5 into chriskalmar:master Jun 7, 2021
@Enubia Enubia deleted the fix/fix-test-type-errors branch June 8, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants