Improve GNU Emacs support for Tomorrow Theme #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing font-lock-builtin-face and change color of font-lock-constant-face and font-lock-variable-name-face.
|
Cool. I'm already using Tomorrow in Emacs 24 and it's working well in cperl-mode but tweaking it for additional modes is even better. |
chriskempson
pushed a commit
that referenced
this pull request
Oct 17, 2012
Improve GNU Emacs support for Tomorrow Theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Chris,
Tomorrow Theme looks really good, and I'm working my way to improving its Emacs 23 and 24 support by adding faces for commonly used modes, as well as updating missing built-in faces. I'm checking in new modes as I go along, trying to respect the original intent of the mode's syntax colouring, while making it look good for every theme variation.
Is this something you are interested in merging back into master?
Cheers,
Arnaud.