Implement Stop button and progress bar #120
Conversation
|
Hey @Shura1oplot! This is awesome stuff! I'll start reviewing all these pull request shortly... Just a little buried under other projects right now, but I don't want you to think I'm ignoring these : ) |
|
@chriskiehl I reverted "make quoting implicit" commit as we are discussing it in the different PR. |
| @@ -108,8 +171,8 @@ def required_section_complete(self): | |||
| def success_dialog(self): | |||
| self.show_dialog(i18n._("execution_finished"), i18n._('success_message'), wx.ICON_INFORMATION) | |||
|
|
|||
| def error_dialog(self, error_msg): | |||
| self.show_dialog(i18n._('error_title'), i18n._('uh_oh').format(error_msg), wx.ICON_ERROR) | |||
There was a problem hiding this comment.
Why did you drop the error here (and in the translations file)?
Gooey should bubble up why the program failed.
Edit: Ah, I see now. The stop button pushes Gooey to the error screen, which would then show the stacktrace for the user purposefully stopping the program.
In the case of an actual error, the error message should still be shown to the user. So we need to either (a) conditionally show the stacktrace, or (b) route the stop button to a different screen.
There was a problem hiding this comment.
@chriskiehl Gooey catches stderr to show python exceptions in a error dialog. It doesn't work as designed when wrapped program uses stderr to print messages to user and stdout to optional data out. Lots of unix tools work like this, for example, wget and dd. Also it solves buffered output issue from frozen programs as stderr is always unbuffered.
There was a problem hiding this comment.
@Shura1oplot Hmm... this is interesting. I didn't know it was common to pump non error messages over stderr. You're exposing my noobish level of linux knowledge! ; )
After spending a few minutes reading up on the behavior, I yield to your explanation. I can see why programs would use stderr for things other than a simple error stream.
So... as you said, it seems Gooey's original behavior was indeed broken.
Good fix!
|
@chriskiehl excuse me for a long delay, I have "busy season" on my work. I have fixed thing noted above. |
|
Merged! Awesome work, man! |
Added Stop button to the screen with status of running program. Depend on the OS it uses os.kill to terminale the process or TASKKILL.EXE windows program.
Added progress bar support. Two new
Gooey()options added:progress_regexandprogress_expr. The first one should be regular expression which is applied to each line of the program output. At least one group in the regex should be defined. If the regexp matchs a line, progress bar is updated. In caseprogress_expris not set, the group should contain a float number between 0 and 100, otherwiseprogress_expris applied as an argument toexpr()function. All unnamed regexp groups are passed asxvariable withlisttype, named groups are passed as variables. If a group value can be converted to float, it will be. For usage please refer toexample_progress_bar_*.py.