Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WinOS paths issues in MultiDirChooser #900

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ChenglongMa
Copy link

Hello there!

Make sure you've followed the Contributing guidelines before finalizing your pull request.

TL;DR:

  • You're opening this PR against the current release branch
  • Works on both Python 2.7 & Python 3.x
  • Commits have been squashed and includes the relevant issue number
  • Pull request description contains link to relevant issue or detailed notes on changes
  • This must include example code demonstrating your feature or the bug being fixed
  • All existing tests pass
  • Your bug fix / feature has associated test coverage
  • README.md is updated (if relevant)

Changelog

Since wxPython v4.2.1 has been released, it has fixed the wxWidgets/Phoenix#2120 issue (in v4.2.0).

It's time to roll back to the version before #554.
Also, this PR is related to #854.

Thanks!

@ChenglongMa
Copy link
Author

Or you can restrict the version number of wxPython to 4.1.0:

In requirements.txt

wxpython==4.1.0

In setup.py

deps = [
    ...
    'wxpython==4.1.0',
    ...
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant