Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.66 API breaking change in io_context constructor #601

Open
ghost opened this issue Dec 30, 2020 · 0 comments
Open

1.66 API breaking change in io_context constructor #601

ghost opened this issue Dec 30, 2020 · 0 comments

Comments

@ghost
Copy link

ghost commented Dec 30, 2020

@StephanDollberg commented on Feb 17, 2018, 8:57 PM UTC:

Hello,

1.66 introduced an API breaking change in the constructor of io_context.

io_context takes an int while io_service took a std::size_t. Compare v1.66 and v1.65. This change breaks all code that stored a std::size_t which later got passed to the io_service constructor due to a now narrowing conversion.

I think this should either be fixed or noted on http://www.boost.org/doc/libs/1_66_0/doc/html/boost_asio/net_ts.html as io_service is not a strict typedef but a different type.

For example, see microsoft/cpprestsdk#654.

thanks,
Stephan

This issue was moved by chriskohlhoff from boostorg/asio#89.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants