Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.66 API breaking change in io_context constructor #89

Closed
StephanDollberg opened this issue Feb 17, 2018 · 1 comment
Closed

1.66 API breaking change in io_context constructor #89

StephanDollberg opened this issue Feb 17, 2018 · 1 comment

Comments

@StephanDollberg
Copy link

StephanDollberg commented Feb 17, 2018 •
edited

Hello,

1.66 introduced an API breaking change in the constructor of io_context.

io_context takes an int while io_service took a std::size_t. Compare v1.66 and v1.65. This change breaks all code that stored a std::size_t which later got passed to the io_service constructor due to a now narrowing conversion.

I think this should either be fixed or noted on http://www.boost.org/doc/libs/1_66_0/doc/html/boost_asio/net_ts.html as io_service is not a strict typedef but a different type.

For example, see microsoft/cpprestsdk#654.

thanks,
Stephan
@ghost ghost mentioned this issue Dec 30, 2020
Open
@ghost ghost deleted a comment from chriskohlhoff Dec 30, 2020
@ghost
Copy link

ghost commented Dec 30, 2020

This issue was moved by chriskohlhoff to chriskohlhoff/asio#601.

@ghost ghost closed this as completed Dec 30, 2020
@ghost ghost locked and limited conversation to collaborators Dec 30, 2020
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@StephanDollberg