Fix #84 Logging blank filename #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new utility function called `getFileDetails()` in a
new file `utils.js`. This function takes a URL as an argument and
returns an object containing the path, file name, and file extension of
the URL.
For example, `getFileDetails("https://example.com/foo/bar/baz.txt")`
would return `{path: "/foo/bar/", name: "baz", ext: ".txt"}`.
The `fetcher.js` file has been updated to use this function instead
of `String.split()` when fetching data from a URL. This helps resolving
URLs and extracting file information at once.
- Installed jest@29.7.0, @babel/preset-env@7.23.7, babel-polyfill@6.26.0, babel-jest@29.7.0 as development dependencies - Added a test script in `package.json` to run jest with a custom configuration file in `jest.config.js` - Added a Jest extension setting for VS Code
This commit adds a new unit test file called `utils.test.js` in the `test` folder. This file contains a test suite for the `getFileDetails()` function in `utils.js`. The test suite uses Jest as the testing framework and checks the following scenarios: - The function returns an object with the correct properties (path, fileName, fileExtension) for a valid URL - The function returns the correct file details for a URL with query parameters - The function returns the correct file details for a URL with a fragment identifier The test suite has been run and passed with 100% coverage for the `getFileDetails()` function.
- Moved `utils.test.js` to `__tests__` folder to separate it from non-Jest test files - Modified the `input` parameter in `rollup.config.js` to prevent Jest test (`__tests__/*.test.js`) files from being included in the `bundle.js` output - Added `testMatch` to force Jest to detect test files from `__tests__` folder
chriskyfung
added
bug
This commit prevents the fetcher.js module to add a new row to the log sheet even if the file was not successfully saved to Google Drive. The fix only adding a new row to the log if the return value of the `createViewFileFormula()` is not empty. This ensures that the log file reflects the actual status of the file saving operation. Fixes: #84
chriskyfung
force-pushed
the
84-fix-logging-blank-filename
branch
from
3d4789b
to
5265665
Compare
Closed
chriskyfung
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prevents the fetcher.js module to add a new row to the log
sheet even if the file was not successfully saved to Google Drive.
The fix only adding a new row to the log if the return value of the
createViewFileFormula()is not empty. This ensures that the log filereflects the actual status of the file saving operation.
Fixes: #84