Show some sort of interaction/animation/feedback when favoriting a tweet

[gena01]

Would be nice to see some sort of visual after pressing the favorite (star) icon.

Right now it can take several seconds for a tweet to become "favorite". Currently i look to see if there's any network activity to see if it's "working"

[BlythMeister]

The tweet is marked as favorite by tagging the corner.

Does this not work for you?

[jamesduffy]

I think the question is asking about before it is favorited and the request
is in process of being completed.

On Tue, Jul 30, 2013 at 2:09 PM, Chris Blyth notifications@github.comwrote:

The tweet is marked as favorite by tagging the corner.

Does this not work for you?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/217#issuecomment-21823114
.

[BlythMeister]

Oh when the background action going to Twitter...what sort of behaviour are you expecting?

[gena01]

Some sort of a visual i guess.

Maybe a pressed or different star icon or something else? Could be a progress bar, a spinner, a modal, etc...

[gena01]

Tweetdeck used to show a "pressed" star button image that would release and show a star if the tweet was favorited successfully.

[gena01]

Tweetdeck used to show a "pressed" star button image that would release and show a star if the tweet was favorited successfully.

[jamesduffy]

I would make sure there is some kind of touch feedback (
http://developer.android.com/design/style/touch-feedback.html) on the
star/retweet, make the icon fill-in and then make the request. We can show
the user a message if it fails, but otherwise should not show a toast.

On Tue, Jul 30, 2013 at 2:25 PM, Gennady Feldman
notifications@github.comwrote:

Some sort of a visual i guess.

Maybe a pressed or different star icon or something else? Could be a
progress bar, a spinner, a modal, etc...

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/217#issuecomment-21824086
.

[BlythMeister]

Thing is the buttons etc all go when you do something.

When I favorite it takes less than a second to actually show the toast.

Not sure what we can do with the way the UI works other that a toast saying sending favorite?

[jamesduffy]

Change the state of the icon when pressed and send the request after
without the users having to wait a full second or more. If it fails we can
revert the favorites state and show am error toast.
On Jul 30, 2013 10:51 PM, "Chris Blyth" notifications@github.com wrote:

Thing is the buttons etc all go when you do something.

When I favorite it takes less than a second to actually show the toast.

Not sure what we can do with the way the UI works other that a toast
saying sending favorite?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/217#issuecomment-21841593
.

[Fammy]

Fixed by #218

[BlythMeister]

@sinisterdragon could we apply the same change to the RT button? - just for consistency.

[BlythMeister]

Can't see this when I favorite something as the action bar closes straight away.

Also, in the tweet spotlight this doesn't seem to show, even though the action bar is always shown.

[matt-valdez]

Yeah I'll add it to the RT as well.

I'm using it now and I see it switch. Using both themes. See it when I
click a tweet than I hit the favorite icon.
On Aug 2, 2013 2:34 AM, "Chris Blyth" notifications@github.com wrote:

Can't see this when I favorite something as the action bar closes straight
away.

Also, in the tweet spotlight this doesn't seem to show, even though the
action bar is always shown.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/217#issuecomment-21990706
.

[BlythMeister]

@sinisterdragon sorry, i've looked again and can see it when on the tweet spotlight...just (it's very very subtle)

Though i can't see it when on the main tweet view as the action bar disapears.

In summary:

=> Can we include on the lane when selecting (may have some issues around the action bar closing straight away)
=> Can we make it more obvious...i had to look really close to see it.
=> Can we get the same functionality on RT

thanks 😄 i don't want much lol 😦

[matt-valdez]

Haha I'll make the glow more prominent.
Its especially subtle if you are using a dark theme or light w/ dark action bar theme

If you want some sort of feedback when selecting from a lane it is going to have to be a different feedback. Perhaps a toast that says "Loading..." or a progress spinner. But since the Context menu is designed to disappear when an action is clicked it is going to be impossible to implement the same visual queue as with the spotlight view.

[Fammy]

Icon doesn't match on the newly merged Holo Light with Dark Action Bar theme.

[matt-valdez]

What do you mean? Favorite icon and pressed work but it is hard to tell cause it isn't very prominent. I will work on making it more prominent

[BlythMeister]

Updated label to in progress as @sinisterdragon is working on this item