Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New posts/tweets bar will reappear after reading all new posts #75

Closed
jamesduffy opened this issue May 17, 2013 · 13 comments
Closed

New posts/tweets bar will reappear after reading all new posts #75

jamesduffy opened this issue May 17, 2013 · 13 comments
Assignees
Labels
Milestone

Comments

@jamesduffy
Copy link
Collaborator

The "{count} New Posts" blue bar will reappear in the lanes after viewing all new posts.

To reproduce:

  1. Go to a lane with new posts,
  2. Scroll to the top until the message appears,
  3. Scroll a few posts back down,
  4. When scrolling up the blue bar will reappear.
@BlythMeister
Copy link
Collaborator

Does this still happen? I can't seem to repo it?

@BlythMeister
Copy link
Collaborator

This should now be resolved.

@Fammy
Copy link
Contributor

Fammy commented Jun 15, 2013

Fix by a new pull request or one of your previous ones?

@BlythMeister
Copy link
Collaborator

As part of a previous one.

Had a bit of a play around with that bar, and hopefully have it working correctly now.

@BlythMeister
Copy link
Collaborator

But obvs needs a re-test on more devices

@jamesduffy
Copy link
Collaborator Author

Still happening on the latest beta.

@Fammy
Copy link
Contributor

Fammy commented Jun 16, 2013

I've seen "0 new tweets" (or posts). Is that intentional?

@BlythMeister
Copy link
Collaborator

I think it's fixed after yeserdays changes...don't think they been built yet.

@BlythMeister
Copy link
Collaborator

0 new tweets fixed today (i hope)

@Fammy
Copy link
Contributor

Fammy commented Jun 16, 2013

That last built beta is a few days out of date.

@BlythMeister
Copy link
Collaborator

@jamesduffy out of interest, do you mean you want the bar to disapear alltogether as you scroll down before the last tweet you seen.

So only show the blue bar when your on a tweet that is new?

@jamesduffy
Copy link
Collaborator Author

I would mimic the Google+ app. It hides as you scroll down, but when you
scroll up a little bit (not all the way up) the new post bar at the bottom
will appear.

On Mon, Jun 17, 2013 at 1:41 AM, Chris Blyth notifications@github.comwrote:

@jamesduffy https://github.com/jamesduffy out of interest, do you mean
you want the bar to disapear alltogether as you scroll down before the last
tweet you seen.

So only show the blue bar when your on a tweet that is new?


Reply to this email directly or view it on GitHubhttps://github.com//issues/75#issuecomment-19532514
.

@ghost ghost assigned BlythMeister Jun 18, 2013
@BlythMeister
Copy link
Collaborator

This is now fixed to an extent, with a new issue raised to make the bar a little nicer.
But more UI work will be required for that.

@jamesduffy can this one be closed?

@Fammy Fammy closed this as completed Jun 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants