Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Refresh Times #84

Closed
BlythMeister opened this issue May 30, 2013 · 14 comments
Closed

Custom Refresh Times #84

BlythMeister opened this issue May 30, 2013 · 14 comments

Comments

@BlythMeister
Copy link
Collaborator

Would it be possible to include custom refresh times.
It looks like it's hard coded to 15 minutes in here:
https://github.com/chrislacy/TweetLanes/blob/master/android/client/src/com/tweetlanes/android/Notifier.java#L76

@Fammy
Copy link
Contributor

Fammy commented May 30, 2013

It is hard coded to 15 minutes for batter-life to usability concerns. I'd like to add a dropdown to let you select. Anything less than 15 minutes is going to kill battery life.

My thoughts for options, based on what Android optimizes for are:
[5 minutes - Kill battery]
[15 minutes]
[1 hour]
[4 hour]
[1 day]

@BlythMeister
Copy link
Collaborator Author

Ide like to cut my teeth at android dev. Maybe this is a good starting point for me to try?

@Fammy
Copy link
Contributor

Fammy commented May 30, 2013

Of course! You will probably want to look at SettingsActivity as well as Notifier. Send a pull request and I'll review and merge it.

@BlythMeister
Copy link
Collaborator Author

Great thanks...first step making the ide work :-)

@BlythMeister
Copy link
Collaborator Author

@Fammy when i load up the IDE i'm seeing i need android-support-v13.jar.
Is there anywhere i can get help to get started?

@Fammy
Copy link
Contributor

Fammy commented May 31, 2013

I recently removed that. You should be working off the develop branch. Let
me make sure I've pushed all my changes.

Jason Famularo
jason@famularo.org

On Fri, May 31, 2013 at 2:51 AM, Chris Blyth notifications@github.comwrote:

@Fammy https://github.com/Fammy when i load up the IDE i'm seeing i
need android-support-v13.jar.
Is there anywhere i can get help to get started?


Reply to this email directly or view it on GitHubhttps://github.com//issues/84#issuecomment-18726095
.

@BlythMeister
Copy link
Collaborator Author

whoops, i'll double check and make sure i'm doing it correctly.

@BlythMeister
Copy link
Collaborator Author

@Fammy on the develop branch and had 2 issues.

  1. .classpath still says v13. - i changed to v4 and got further
  2. no twitter4j.jar. went to twitter4j site and got version twitter4j-core-3.0.3.jar (don't know if that is correct)

but the app won't start, looks like it can't create the api on line 91 in org.tweetalib.TwitterManager

Are you able to help?

@BlythMeister
Copy link
Collaborator Author

FYI, the error i get is:
image

@BlythMeister
Copy link
Collaborator Author

@BlythMeister
Copy link
Collaborator Author

Pull request 86 sent with fix.

@Fammy
Copy link
Contributor

Fammy commented Jun 1, 2013

I've been using IntelliJ Idea. I have no idea (pun intended) if Eclipse still works. Sorry for the confusion. I'll review this pull request shortly.

Fammy added a commit that referenced this issue Jun 1, 2013
Fix for Issue #84 - Custom Notification Timings
@BlythMeister
Copy link
Collaborator Author

Good news is, that eclipse now works :-)
Hopefully your IDE still works too.

@Fammy
Copy link
Contributor

Fammy commented Jun 1, 2013

It did!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants