Update Validator.java #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated t.co url length values
|
I'll take a look at this and get it in the 0.73.0 release. I also want to update to the latest com.twitter tools, which may have this fix as well. If that proves difficult (Chris made custom changes), I'll accept this pull request as the short term solution. |
ghost
assigned 
|
Went with your change. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The t.co URL shorter length needs to be increased as currently the hard coded values are shorter than the generated URLs returned by twitter causing the characters left count when composing a tweet to be incorrect and post failure notifications when trying to tweet.
Current values should be as detailed via the following api call:
https://dev.twitter.com/docs/api/1.1/get/help/configuration
A short term fix will be to increase the values in the following file
https://github.com/chrislacy/TweetLanes/blob/master/android/libraries/SocialNetLib/src/com/twitter/Validator.java - pull request: #50
Long term is to use the api call and use the values returned by the api.
Also, to note, there needs to be an additional value for tweets with media, currently twitter returns URLs with 23 characters which is 1 more than the non-HTTPS URLs and the same as HTTPS URLs.
sorry for the duplicates, never realised it would open an issue when I submitted the pull...