Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: order status update #461

Merged
merged 9 commits into from
Aug 10, 2022
Merged

fix: order status update #461

merged 9 commits into from
Aug 10, 2022

Conversation

chrisleekr
Copy link
Owner

Description

After receiving the order status via WebSocket, the trailing trade process was not executed unless the tick is received.
However, the symbol should be processed after the order status is updated to determine what to do with the updated order.

Related Issue

#451

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022

Codecov Report

Merging #461 (499e667) into master (8160e25) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #461   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           87        87           
  Lines         3179      3182    +3     
  Branches       548       548           
=========================================
+ Hits          3179      3182    +3     
Impacted Files Coverage Δ
...p/cronjob/trailingTrade/step/handle-open-orders.js 100.00% <ø> (ø)
app/binance/user.js 100.00% <100.00%> (ø)
app/server.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@uhliksk
Copy link
Contributor

uhliksk commented Aug 10, 2022

Note: stepName should be visible in log view even when correlationId is not available. Should you use uuid instead of collerationID in this case?

image

@chrisleekr
Copy link
Owner Author

TradingView recommendation update does not trigger any action. Hence, does not need UUID to trace.
I see some improvement I can make, but I guess that can be done later.

@chrisleekr chrisleekr linked an issue Aug 10, 2022 that may be closed by this pull request
@chrisleekr chrisleekr merged commit a2cd38e into master Aug 10, 2022
@chrisleekr chrisleekr added the bug Something isn't working label Aug 10, 2022
@chrisleekr chrisleekr deleted the fix/order-status-update branch August 14, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doubled or missing sell orders since websocket implemented
3 participants