Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show buy/sell order details in the grid trade sections #527

Merged
merged 1 commit into from
Oct 15, 2022
Merged

feat: show buy/sell order details in the grid trade sections #527

merged 1 commit into from
Oct 15, 2022

Conversation

rando128
Copy link
Contributor

Description

Improve the frontend with information about the recent orders that took place in the current grid trading.

Motivation and Context

Today there is no way to get the details of buy and sell orders that the bot executed in a specific coin grid. This PR is about showing the date, price, quantity and amount for each buy/sell order happening in an active trading grid.

How Has This Been Tested?

This PR simply expands the grid trade sections with order details ( date, price, quantity, amount) only when the grid got executed. This has been tested on my local setup with multi-grid coins.

I couldn't write tests as I couldn't find existing tests dealing with UI aspects that I could reuse.

Screenshots (if appropriate):

Screenshot 2022-10-14 at 18 54 10

@chrisleekr chrisleekr merged commit e6ffa6e into chrisleekr:master Oct 15, 2022
@chrisleekr
Copy link
Owner

@rando128
This is amazing feature. Thank you!

@rando128 rando128 deleted the feat/show-order-details-in-signal-wrappers branch October 15, 2022 06:31
@peweb
Copy link

peweb commented Nov 29, 2022

@chrisleekr is this added to the main release?
Cant find it in my frontend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants